fix: decode exiftool JSON output as UTF-8 instead of locale encoding#1994
Open
hanhan761 wants to merge 1 commit into
Open
fix: decode exiftool JSON output as UTF-8 instead of locale encoding#1994hanhan761 wants to merge 1 commit into
hanhan761 wants to merge 1 commit into
Conversation
ExifTool always outputs JSON in UTF-8 (per RFC 8259), but the exiftool_metadata() function decoded the output using locale.getpreferredencoding(). On systems with non-UTF-8 locale encoding (e.g. Windows with Chinese locale cp936), this caused UnicodeDecodeError when ExifTool returned non-ASCII metadata. Fix: - Use encoding='utf-8' instead of text=True in version-check subprocess.run() so stdout is decoded as UTF-8. - Decode JSON output bytes with 'utf-8' instead of locale.getpreferredencoding(). - Remove unused import of locale. Fixes microsoft#1972
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExifTool always outputs JSON in UTF-8 (per RFC 8259), but the exiftool_metadata() function decoded the output using locale.getpreferredencoding(). On systems with non-UTF-8 locale encoding (e.g. Windows with Chinese locale cp936), this caused UnicodeDecodeError when ExifTool returned non-ASCII metadata.
Changes
Verification
Backward Compatibility
Fixes #1972