This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Fixing bug where title was not saved when Save button is clicked - #391
Merged
Eric Johnson (EricJohnson327) merged 1 commit intoMay 15, 2024
Merged
Conversation
Felipe G (guimafelipe)
requested review from
Eric Johnson (EricJohnson327),
David Bennett (dkbennett) and
Kristen Schau (krschau)
May 13, 2024 20:02
Kristen Schau (krschau)
approved these changes
May 13, 2024
Eric Johnson (EricJohnson327)
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR fixes a bug where if the user changes the title of the widget and clics "Save" button, the configuration is not saved.
Now, whenever the "Save" action is invoked, we save the data as the
ConfigurationDataof the widget.References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist