Ensure we don't override XamlLanguage if it's already set. - #979
Merged
Conversation
Contributor
Author
|
This is a very straightforward change. I think we can skip the extensive validation of the OS for this. I validated with YourPhone. |
Kenny Kerr (kennykerr)
approved these changes
Jul 9, 2021
Collaborator
|
While Dale is updating the OS compiler vpack, I don't think he's updating the msbuild vpack. Did you want to do that or is there not really any value? |
Contributor
Author
|
Yeah let's do it. Best to be in sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When NuGet imports the props as part of PackageReference, it easy to end up in situations where the project file defines XamlLanguage before the C++/WinRT props are imported.
We shouldn't override if the value is already set.