Runtime class name for bare IInspectable should not be "Object" - #930
Merged
Conversation
This tickles an edge case in the metadata-based marshaller. Use an empty string instead.
Raymond Chen (oldnewthing)
requested review from
Chris Guzak (ChrisGuzak) and
Kenny Kerr (kennykerr)
April 23, 2021 23:44
| }; | ||
|
|
||
| template <> | ||
| struct runtime_class_name<Windows::Foundation::IInspectable> |
Member
Author
There was a problem hiding this comment.
Note that name_of still returns Object, which is necessary for proper autogeneration of parameterized interfaces.
Collaborator
There was a problem hiding this comment.
Yep, that's kinda important. 😉
Chris Guzak (ChrisGuzak)
approved these changes
Apr 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tickles an edge case in the metadata-based marshaller. Use an empty string instead.