Fix support for x86 builds with Clang - #889
Merged
Kenny Kerr (kennykerr) merged 3 commits intoMar 12, 2021
Merged
Conversation
|
|
Collaborator
|
FYI Raymond Chen (@oldnewthing) this is fixing a regression introduced in #662. |
Co-authored-by: Kenny Kerr <kenny@kennykerr.ca>
Co-authored-by: Kenny Kerr <kenny@kennykerr.ca>
Kenny Kerr (kennykerr)
approved these changes
Mar 12, 2021
Kenny Kerr (kennykerr)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix! Don't forget to complete the CLA.
Contributor
Author
|
Done happy to contribute ! |
Member
|
Ah, I see. clang lambdas are implicitly convertible to |
Collaborator
|
Yes, Visual C++ provides overloads for all calling conventions (a very cool feature) but this is apparently not required by the standard and Clang declines to do the same. |
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #879