Clang workarounds - #867
Merged
Merged
Conversation
Kenny Kerr (kennykerr)
requested review from
Ryan Shepherd (DefaultRyan) and
Raymond Chen (oldnewthing)
March 4, 2021 16:17
Raymond Chen (oldnewthing)
approved these changes
Mar 4, 2021
| [[noreturn]] inline void __stdcall fallback_RoFailFastWithErrorContext(int32_t) noexcept | ||
| { | ||
| std::terminate(); | ||
| abort(); |
There was a problem hiding this comment.
I'm somewhat surprised that we don't have to say std::abort() here, but obviously it's working somehow.
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versions of STL typically used with Clang don't corrently attribute
std::terminatewith[[noreturn]].Clang incorrectly fails to see the static constexpr member.