Return the full path to the generated WinMD. - #824
Merged
Conversation
Johan Laanstra (jlaanstra)
requested review from
Scott Jones (Scottj1s) and
Kenny Kerr (kennykerr)
December 15, 2020 21:26
4 tasks
Johan Laanstra (jlaanstra)
force-pushed
the
user/jlaans/809
branch
from
December 15, 2020 23:04
ce315b6 to
c47005c
Compare
Scott Jones (Scottj1s)
approved these changes
Dec 16, 2020
Scott Jones (Scottj1s)
left a comment
Member
There was a problem hiding this comment.
Thanks for the ongoing cppwinrt build support!
Chris Guzak (ChrisGuzak)
approved these changes
Dec 17, 2020
Contributor
Author
|
Completed validation. |
Collaborator
|
Queued build 2.0.201217.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the GetResolvedWinMD target that causes a relative path to be returned by the Build target causing problems when the target started the build tries to resolve the output.
Fixes #809 and dotnet/msbuild#5412
Validate: