This repository was archived by the owner on May 20, 2025. It is now read-only.
feat(auth): conditionally render auth providers - #16
Merged
Lukas Cenovsky (lucen-ms) merged 1 commit intoOct 18, 2024
Merged
Conversation
Added flags to toggle GitHub and Microsoft auth in the UI based on availability, improving UX by showing only enabled options.
| <a href="/auth/<%=action%>/microsoft"><img class="microsoft" src="images/windows10.png"> Microsoft (Personal)</a> | ||
| <span class="spacer"/> | ||
| <a href="/auth/<%=action%>/azure-ad"><img class="microsoft" src="images/windows10.png"> Microsoft (Work)</a><br /> | ||
| <% if (isGitHubAuthenticationEnabled) { %> |
Collaborator
There was a problem hiding this comment.
We don't want to hide authentication if it is not available.
There was a problem hiding this comment.
We don't want to hide authentication if it is not available.
So, a broken button is better ? 🙃
Collaborator
There was a problem hiding this comment.
You are right, I misunderstood the change. Thank you.
Lukas Cenovsky (lucen-ms)
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added flags to toggle GitHub and Microsoft auth in the UI based on availability, improving UX by showing only enabled options.