Skip to content

Allow missing return for void any union#6512

Merged
mhegazy merged 4 commits intomicrosoft:masterfrom
masaeedu:allowMissingReturnForVoidAnyUnion
Jan 25, 2016
Merged

Allow missing return for void any union#6512
mhegazy merged 4 commits intomicrosoft:masterfrom
masaeedu:allowMissingReturnForVoidAnyUnion

Conversation

@masaeedu
Copy link
Copy Markdown
Contributor

@masaeedu masaeedu commented Jan 16, 2016

Fixes #6326

@msftclas
Copy link
Copy Markdown

msftclas commented Jan 16, 2016

Hi @masaeedu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link
Copy Markdown

msftclas commented Jan 16, 2016

@masaeedu, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@masaeedu masaeedu force-pushed the allowMissingReturnForVoidAnyUnion branch from 07f95f3 to eb87bad Compare January 16, 2016 05:19
RyanCavanaugh
RyanCavanaugh reviewed Jan 19, 2016
View reviewed changes
Comment thread doc/spec.md
Copy link
Copy Markdown
Member

@RyanCavanaugh RyanCavanaugh Jan 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You actually need to update the Word document (which is the authoritative source) and then run the word2md script to update this file.

Alternatively, just skip this change and log a spec bug to handle the change.

@plantain-00 plantain-00 mentioned this pull request Jan 24, 2016
Closed
3 tasks
@masaeedu
Copy link
Copy Markdown
Contributor Author

masaeedu commented Jan 25, 2016

@RyanCavanaugh Any other changes needed to get this merged?

@RyanCavanaugh
Copy link
Copy Markdown
Member

RyanCavanaugh commented Jan 25, 2016

@mhegazy good with this?

@DanielRosenwasser
Copy link
Copy Markdown
Member

DanielRosenwasser commented Jan 25, 2016

👍

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Jan 25, 2016

thanks!

mhegazy added a commit that referenced this pull request Jan 25, 2016
@mhegazy
Merge pull request #6512 from masaeedu/allowMissingReturnForVoidAnyUnion
85d09e4 
Allow missing return for void any union
@mhegazy mhegazy merged commit 85d09e4 into microsoft:master Jan 25, 2016
@masaeedu masaeedu deleted the allowMissingReturnForVoidAnyUnion branch January 25, 2016 23:15
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@masaeedu @msftclas @RyanCavanaugh @DanielRosenwasser @mhegazy