Fixed crash in `hasVisibleDeclarations` related to binding elements by Andarist · Pull Request #61352 · microsoft/TypeScript

Mateusz Burzyński (Andarist) · 2025-03-04T23:18:25Z

Ryan Cavanaugh (RyanCavanaugh) · 2025-06-17T16:49:08Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2025-06-17T16:49:13Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	❌ Results

TypeScript Bot (typescript-bot) · 2025-06-17T17:11:17Z

Hey Ryan Cavanaugh (@RyanCavanaugh), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2025-06-17T17:14:08Z

Ryan Cavanaugh (@RyanCavanaugh) Here are the results of running the user tests with tsc comparing main and refs/pull/61352/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2025-06-17T17:22:05Z

Ryan Cavanaugh (@RyanCavanaugh), the perf run you requested failed. You can check the log here.

TypeScript Bot (typescript-bot) · 2025-06-17T18:31:56Z

Ryan Cavanaugh (@RyanCavanaugh) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61352/merge:

Everything looks good!

Bjørn Arnholtz (bjornua) · 2025-06-23T14:38:43Z

Ryan Cavanaugh (@RyanCavanaugh) Looks like the perf test this faster command fails because @electron/get@4.0.1 requires Node.js version >=22.12.0, but the Docker container is running Node.js 20.19.2.

Another example of a PR where it fails: #61888. Seems to be a general CI issue

Jake Bailey (jakebailey) · 2025-06-23T16:05:38Z

I've already fixed it.

TypeScript Bot (@typescript-bot) perf test this faster

TypeScript Bot (typescript-bot) · 2025-06-23T16:05:43Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2025-06-23T16:58:26Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,500k (± 0.76%)}	_{195,924k (± 0.75%)}	_{+2,424k (+ 1.25%)}	_192,913k	_196,566k	_{p=0.020 n=6}
_{Parse Time}	_1.31s	_{1.31s (± 0.39%)}	_~	_1.31s	_1.32s	_{p=0.174 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.70s (± 0.62%)}	_{9.69s (± 0.47%)}	_~	_9.65s	_9.78s	_{p=0.936 n=6}
_{Emit Time}	_{2.75s (± 0.80%)}	_{2.74s (± 0.55%)}	_~	_2.73s	_2.77s	_{p=0.618 n=6}
_{Total Time}	_{14.48s (± 0.53%)}	_{14.48s (± 0.32%)}	_~	_14.42s	_14.56s	_{p=0.810 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,750	_948,750	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,846	_410,846	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,604k (± 0.01%)}	_{1,224,644k (± 0.00%)}	_~	_1,224,572k	_1,224,706k	_{p=0.471 n=6}
_{Parse Time}	_{6.60s (± 0.50%)}	_{6.57s (± 0.36%)}	_~	_6.53s	_6.60s	_{p=0.192 n=6}
_{Bind Time}	_{1.88s (± 0.43%)}	_{1.88s (± 0.58%)}	_~	_1.86s	_1.89s	_{p=0.666 n=6}
_{Check Time}	_{31.77s (± 0.29%)}	_{31.89s (± 0.25%)}	_{+0.12s (+ 0.37%)}	_31.78s	_32.00s	_{p=0.043 n=6}
_{Emit Time}	_{14.89s (± 0.44%)}	_{14.89s (± 0.68%)}	_~	_14.74s	_15.02s	_{p=1.000 n=6}
_{Total Time}	_{55.14s (± 0.22%)}	_{55.23s (± 0.19%)}	_~	_55.10s	_55.38s	_{p=0.296 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,509,169	_2,509,169	_~	_~	_~	_{p=1.000 n=6}
_Types	_892,704	_892,704	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,803,926k (± 0.00%)}	_{2,803,917k (± 0.00%)}	_~	_2,803,863k	_2,803,978k	_{p=1.000 n=6}
_{Parse Time}	_{8.86s (± 0.27%)}	_{8.84s (± 0.36%)}	_~	_8.80s	_8.89s	_{p=0.146 n=6}
_{Bind Time}	_{2.23s (± 0.28%)}	_{2.24s (± 0.61%)}	_~	_2.22s	_2.26s	_{p=0.388 n=6}
_{Check Time}	_{84.10s (± 0.23%)}	_{84.32s (± 0.23%)}	_~	_84.00s	_84.56s	_{p=0.128 n=6}
_{Emit Time}	_{0.30s (± 2.11%)}	_0.30s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{95.49s (± 0.20%)}	_{95.69s (± 0.20%)}	_~	_95.38s	_95.88s	_{p=0.109 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,126	_1,227,127	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,408	_267,407	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,545,041k (±11.98%)}	_{2,362,132k (± 0.02%)}	_{🟩-182,908k (- 7.19%)}	_2,361,620k	_2,362,668k	_{p=0.020 n=6}
_{Parse Time}	_{5.25s (± 1.06%)}	_{5.20s (± 1.12%)}	_~	_5.14s	_5.29s	_{p=0.173 n=6}
_{Bind Time}	_{1.79s (± 1.08%)}	_{1.81s (± 0.81%)}	_~	_1.79s	_1.83s	_{p=0.084 n=6}
_{Check Time}	_{35.10s (± 0.67%)}	_{35.41s (± 0.79%)}	_~	_35.07s	_35.70s	_{p=0.093 n=6}
_{Emit Time}	_{2.99s (± 1.35%)}	_{2.99s (± 0.95%)}	_~	_2.95s	_3.03s	_{p=1.000 n=6}
_{Total Time}	_{45.15s (± 0.61%)}	_{45.42s (± 0.73%)}	_~	_45.02s	_45.79s	_{p=0.378 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,126	_1,227,127	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,408	_267,407	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,796,184k (±14.27%)}	_{3,038,920k (± 9.76%)}	_~	_2,432,817k	_3,161,172k	_{p=0.810 n=6}
_{Parse Time}	_{6.83s (± 1.52%)}	_{6.85s (± 0.92%)}	_~	_6.74s	_6.92s	_{p=0.873 n=6}
_{Bind Time}	_{2.19s (± 1.87%)}	_{2.14s (± 1.08%)}	_{-0.05s (- 2.21%)}	_2.11s	_2.17s	_{p=0.025 n=6}
_{Check Time}	_{42.69s (± 0.81%)}	_{42.72s (± 0.41%)}	_~	_42.50s	_42.91s	_{p=0.575 n=6}
_{Emit Time}	_{3.49s (± 2.67%)}	_{3.45s (± 1.40%)}	_~	_3.38s	_3.51s	_{p=0.471 n=6}
_{Total Time}	_{55.21s (± 0.82%)}	_{55.17s (± 0.43%)}	_~	_54.84s	_55.44s	_{p=0.298 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,474	_262,475	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_107,135	_107,134	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{441,708k (± 0.02%)}	_{441,704k (± 0.02%)}	_~	_441,508k	_441,785k	_{p=0.936 n=6}
_{Parse Time}	_{3.52s (± 0.73%)}	_{3.54s (± 0.68%)}	_~	_3.51s	_3.58s	_{p=0.258 n=6}
_{Bind Time}	_{1.32s (± 0.62%)}	_{1.33s (± 1.03%)}	_~	_1.32s	_1.36s	_{p=0.121 n=6}
_{Check Time}	_{18.85s (± 0.42%)}	_{18.85s (± 0.18%)}	_~	_18.80s	_18.88s	_{p=0.748 n=6}
_{Emit Time}	_{1.51s (± 0.68%)}	_{1.53s (± 0.79%)}	_~	_1.51s	_1.54s	_{p=0.084 n=6}
_{Total Time}	_{25.21s (± 0.33%)}	_{25.25s (± 0.21%)}	_~	_25.17s	_25.31s	_{p=0.199 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,327	_225,327	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,288	_94,288	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,169k (± 0.05%)}	_{371,138k (± 0.04%)}	_~	_371,021k	_371,434k	_{p=0.936 n=6}
_{Parse Time}	_{2.88s (± 0.96%)}	_{2.89s (± 0.40%)}	_~	_2.87s	_2.90s	_{p=0.250 n=6}
_{Bind Time}	_{1.61s (± 1.16%)}	_{1.60s (± 1.29%)}	_~	_1.58s	_1.64s	_{p=0.569 n=6}
_{Check Time}	_{16.35s (± 0.30%)}	_{16.34s (± 0.34%)}	_~	_16.25s	_16.39s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{20.84s (± 0.31%)}	_{20.84s (± 0.28%)}	_~	_20.72s	_20.88s	_{p=0.936 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,479,209	_3,479,209	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,170,466	_1,170,466	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,528,055k (± 0.01%)}	_{3,528,186k (± 0.00%)}	_~	_3,527,993k	_3,528,449k	_{p=0.298 n=6}
_{Parse Time}	_{18.55s (± 0.37%)}	_{18.53s (± 0.52%)}	_~	_18.43s	_18.67s	_{p=0.689 n=6}
_{Bind Time}	_{5.97s (± 0.98%)}	_{5.96s (± 0.84%)}	_~	_5.89s	_6.04s	_{p=0.809 n=6}
_{Check Time}	_{115.77s (± 1.76%)}	_{114.06s (± 1.35%)}	_~	_113.04s	_117.14s	_{p=0.128 n=6}
_{Emit Time}	_{35.99s (± 2.04%)}	_{36.03s (± 2.17%)}	_~	_35.61s	_37.62s	_{p=0.936 n=6}
_{Total Time}	_{176.28s (± 1.42%)}	_{174.58s (± 1.00%)}	_~	_173.17s	_177.54s	_{p=0.173 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_320,007	_320,007	_~	_~	_~	_{p=1.000 n=6}
_Types	_140,371	_140,371	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{474,255k (± 0.03%)}	_{474,283k (± 0.03%)}	_~	_474,117k	_474,520k	_{p=1.000 n=6}
_{Parse Time}	_{4.33s (± 0.65%)}	_{4.34s (± 0.74%)}	_~	_4.28s	_4.36s	_{p=0.681 n=6}
_{Bind Time}	_{1.76s (± 1.47%)}	_{1.78s (± 1.39%)}	_~	_1.74s	_1.81s	_{p=0.465 n=6}
_{Check Time}	_{20.74s (± 0.41%)}	_{20.81s (± 0.53%)}	_~	_20.68s	_20.95s	_{p=0.575 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.84s (± 0.38%)}	_{26.92s (± 0.45%)}	_~	_26.73s	_27.06s	_{p=0.199 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_667,374	_667,374	_~	_~	_~	_{p=1.000 n=6}
_Types	_198,751	_198,751	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{570,111k (± 0.01%)}	_{570,135k (± 0.01%)}	_~	_570,058k	_570,284k	_{p=0.689 n=6}
_{Parse Time}	_{4.42s (± 0.65%)}	_{4.43s (± 0.82%)}	_~	_4.38s	_4.47s	_{p=0.687 n=6}
_{Bind Time}	_{1.32s (± 0.88%)}	_{1.33s (± 1.13%)}	_~	_1.31s	_1.35s	_{p=0.618 n=6}
_{Check Time}	_{20.46s (± 0.48%)}	_{20.44s (± 0.29%)}	_~	_20.38s	_20.53s	_{p=0.575 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.20s (± 0.37%)}	_{26.20s (± 0.38%)}	_~	_26.10s	_26.30s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Fixed crash in hasVisibleDeclarations related to binding elements

d3cbe82

github-project-automation Bot added this to PR Backlog Mar 4, 2025

github-project-automation Bot moved this to Not started in PR Backlog Mar 4, 2025

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 4, 2025

Jake Bailey (jakebailey) approved these changes Jun 30, 2025

View reviewed changes

github-project-automation Bot moved this from Not started to Needs merge in PR Backlog Jun 30, 2025

Jake Bailey (jakebailey) merged commit 2ea2ecf into microsoft:main Jun 30, 2025

github-project-automation Bot moved this from Needs merge to Done in PR Backlog Jun 30, 2025

Mateusz Burzyński (Andarist) mentioned this pull request Oct 4, 2025

Port "Fixed crash in hasVisibleDeclarations related to binding elements" microsoft/typescript-go#1820

Merged

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Jan 7, 2026

Navigation Menu

Uh oh!

Fixed crash in `hasVisibleDeclarations` related to binding elements - #61352

Fixed crash in `hasVisibleDeclarations` related to binding elements#61352
Jake Bailey (jakebailey) merged 1 commit into
microsoft:mainfrom
Andarist:fix/crash-computed-properties

Mateusz Burzyński (Andarist) commented Mar 4, 2025

Uh oh!

Ryan Cavanaugh (RyanCavanaugh) commented Jun 17, 2025

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 17, 2025 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 17, 2025

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 17, 2025

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 17, 2025

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 17, 2025

Uh oh!

Bjørn Arnholtz (bjornua) commented Jun 23, 2025 •

edited

Loading

Uh oh!

Jake Bailey (jakebailey) commented Jun 23, 2025

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 23, 2025 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 23, 2025

tsc

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

Mateusz Burzyński (Andarist) commented Mar 4, 2025

Uh oh!

Ryan Cavanaugh (RyanCavanaugh) commented Jun 17, 2025

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 17, 2025

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 17, 2025

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 17, 2025

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 17, 2025

Uh oh!

Bjørn Arnholtz (bjornua) commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Jun 23, 2025

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 23, 2025

tsc

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

TypeScript Bot (typescript-bot) commented Jun 17, 2025 •

edited

Loading

Bjørn Arnholtz (bjornua) commented Jun 23, 2025 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jun 23, 2025 •

edited

Loading