Skip to content

Update documentation for fixing lib issues#5461

Merged
mhegazy merged 4 commits intomasterfrom
contributingLibFixes
Nov 3, 2015
Merged

Update documentation for fixing lib issues#5461
mhegazy merged 4 commits intomasterfrom
contributingLibFixes

Conversation

@mhegazy
Copy link
Copy Markdown
Contributor

@mhegazy mhegazy commented Oct 29, 2015

No description provided.

@mhegazy
Copy link
Copy Markdown
Contributor Author

mhegazy commented Oct 29, 2015

//CC: @zhengbli

zhengbli
zhengbli reviewed Oct 29, 2015
View reviewed changes
Comment thread CONTRIBUTING.md Outdated
Copy link
Copy Markdown
Contributor

@zhengbli zhengbli Oct 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src\lib\dom.generated.d.ts and src\lib\webworker.generated.d.ts for consistency

@mhegazy
Update CONTRIBUTING.md
0c3d52e 
respond to review comments
@DanielRosenwasser
Copy link
Copy Markdown
Member

DanielRosenwasser commented Oct 30, 2015

Can you add a README.md in src/lib that simply has the added content? Casual contributors might not even see this change otherwise.

@mhegazy
Copy link
Copy Markdown
Contributor Author

mhegazy commented Oct 30, 2015

Can you add a README.md in src/lib

I could, but most PRs we got were changing the file in the LKG folder (lib) instead. not sure if ppl even thought about looking under src

@sandersn
Copy link
Copy Markdown
Member

sandersn commented Oct 30, 2015

I definitely looked in lib at first, not src/lib. CONTRIBUTING is the right place.

sandersn
sandersn reviewed Oct 30, 2015
View reviewed changes
Comment thread CONTRIBUTING.md Outdated
Copy link
Copy Markdown
Member

@sandersn sandersn Oct 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing slash is disabling the link. I would get rid of the trailing slash or switch to forward slash.

Copy link
Copy Markdown
Member

@DanielRosenwasser DanielRosenwasser Nov 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please use forward slashes everywhere.

@DanielRosenwasser
Copy link
Copy Markdown
Member

DanielRosenwasser commented Oct 30, 2015

I could, but most PRs we got were changing the file in the LKG folder (lib) instead. not sure if ppl even thought about looking under src

Sounds like you should also put a README in the lib directory saying "DO NOT TOUCH THIS." We shouldn't be averse to pointing users in the right direction once they're going in the wrong direction.

mhegazy added a commit that referenced this pull request Nov 3, 2015
@mhegazy
Merge pull request #5461 from Microsoft/contributingLibFixes
485b3ab 
Update documentation for fixing lib issues
@mhegazy mhegazy merged commit 485b3ab into master Nov 3, 2015
@mhegazy mhegazy deleted the contributingLibFixes branch November 3, 2015 01:10
@sparecycles sparecycles mentioned this pull request Dec 3, 2015
Merged
vladima added a commit that referenced this pull request Jan 11, 2016
@vladima
Merge pull request #5461 from Microsoft/useResolvedFileNameWhenResolv…
3f083fe 
…ingImports

Use dedicated type to store paths
This was referenced Jan 11, 2016
Closed
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mhegazy @DanielRosenwasser @sandersn @zhengbli @msftclas