Enable max-statements-per-line lint rule#45475
Merged
RyanCavanaugh merged 2 commits intomicrosoft:mainfrom Aug 16, 2021
Merged
Conversation
max-statements-per-line lint rule
amcasey
approved these changes
Aug 16, 2021
BobobUnicorn
pushed a commit
to BobobUnicorn/TypeScript
that referenced
this pull request
Oct 24, 2021
* Enable the rule * Fix all the violations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@amcasey found this concerning line
TypeScript/src/compiler/tsbuildPublic.ts
Line 1361 in 339ad92
I've turned on the max statements per line rule and fixed all violations. No other suspicious lines were found.
eslint's interpretation of "multiple statements" means this is mostly just regularizing our use of
if (e) { s; }toif (e) s;and effectively banning single-linecb(e => { s; })