Check for watched directories before clearing map#44947
Merged
andrewbranch merged 1 commit intomicrosoft:mainfrom Jul 16, 2021
Merged
Check for watched directories before clearing map#44947andrewbranch merged 1 commit intomicrosoft:mainfrom
andrewbranch merged 1 commit intomicrosoft:mainfrom
Conversation
DanielRosenwasser
approved these changes
Jul 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without any info about a repro of this crash, I’m not sure how to come up with a test for this. However, as @DanielRosenwasser pointed out, the PR where this code was added (#42929) uses defensive checks against
config.watchedDirectoriesbeing undefined elsewhere, so perhaps this was just an oversight.Fixes #44372