Added BindingElement to isSomeImportDeclaration#43387
Merged
armanio123 merged 3 commits intomicrosoft:masterfrom Apr 1, 2021
Merged
Added BindingElement to isSomeImportDeclaration#43387armanio123 merged 3 commits intomicrosoft:masterfrom
armanio123 merged 3 commits intomicrosoft:masterfrom
Conversation
sandersn
requested changes
Mar 26, 2021
Member
sandersn
left a comment
There was a problem hiding this comment.
isSomeImportDeclaration is only called in one place, and that one place is basically the same code as getDeclarationOfAliasSymbol. What happens if you replace symbol.declarations?.find(isSomeImportDeclaration) in checkIdentifier with
else if (isAlias) {
declaration = getDeclarationOfAliasSymbol(symbol)
}I checked and isSomeImportDeclaration (1) allows identifiers (2) disallows exports, but is otherwise the same. Maybe there's a way to get them to share code. If nothing else, isSomeImportDeclaration should move below isAliasSymbolDeclaration.
Contributor
Author
|
Good find. I run the tests and seems like using |
sandersn
approved these changes
Mar 31, 2021
RyanCavanaugh
approved these changes
Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41957
CommonJs imports are now declared as aliases. I have added the
BindingElementkind when looking for import declarations when the import is destructuring.