Dont include auto type reference directives on syntax only server#39472
Dont include auto type reference directives on syntax only server#39472sheetalkamat merged 1 commit intomasterfrom
Conversation
|
Pretty sure I noticed this in the logs but wasn't sure if that's what the syntax server was always doing 😅. Good catch! I think this is fine for our first iteration, but I could imagine expanding this to |
|
As a general principle, I'm happy to strip out as much functionality as possible, because it's easy to add it back later. Having said that, I'm not sure I understand the consequences of this particular change. If we're going to make things like go-to-def and nav-to work across files (including closed files?), it seems like we'd want to include these files? |
|
I think the idea was that we can make go-to-definition work based on explicit |
|
@DanielRosenwasser I get that mixed up every time and it's only been a few weeks since @andrewbranch broke it down for me. 😅 |
|
Well if any of this functionality was intuitive you wouldn't have heard so much about it 😄 |
Detected while working on the goto def on syntax only server that we were including
node_modules/@typesauto type directives on syntax only server. This disables it.I am not sure if this is desired behavior or not though