fix static method reference non-static#38730
Conversation
|
Not sure that the test behavior is correct, please check them. |
|
Just as a heads up, your commits don't seem to be associated with your GitHub account. While this isn't technically a problem, you might care if you want more appropriate attribution. You can either make sure your GitHub account is associated with the email address that you're using for your commits, or rebase and amend your commits to fix the author name and email. If you don't care about any of this stuff, we can start reviewing. |
Oh, I did not notice it, a big thank you! |
|
Friendly ping @DanielRosenwasser ~ |
1 similar comment
|
Friendly ping @DanielRosenwasser ~ |
| } | ||
| } | ||
|
|
||
| return search.includes(baseSymbol || rootSymbol || sym) |
There was a problem hiding this comment.
includes is too new, use one of the helper utilities in core.ts
There was a problem hiding this comment.
Oh, the type of search is Search rather than Array.
| : undefined; | ||
| }; | ||
| const allowBaseTypes = (rootSymbol: Symbol) => | ||
| !(search.parents?.every(parent => !explicitlyInheritsFrom(rootSymbol.parent!, parent, state.inheritsFromCache, checker))); |
There was a problem hiding this comment.
| !(search.parents?.every(parent => !explicitlyInheritsFrom(rootSymbol.parent!, parent, state.inheritsFromCache, checker))); | |
| forEach(search.parents, parent => !explicitlyInheritsFrom(rootSymbol.parent!, parent, state.inheritsFromCache, checker)); |
There was a problem hiding this comment.
should allowBaseTypes be converted to function?
|
Isn't it finished? Why it says CI build is in progress? |
| if (!callback(array[i], i)) { | ||
| return false; | ||
| } | ||
| if (!array) { |
There was a problem hiding this comment.
interesting this should be !length(array) instead
There was a problem hiding this comment.
A little confused, another review says "revert changes in core", so this is also reverted?
sheetalkamat
left a comment
There was a problem hiding this comment.
Please incorporate feedback
sheetalkamat
left a comment
There was a problem hiding this comment.
Two things:
- This only needs to check if static with baseSymbol matches reference symbol so this keeps the change only to that.
- Checking if symbol is static is done only if there is basesymbol so avoids having to check that for other symbols
|
@ShuiRuTian thank you for working on this |
Fixes #37830