Merged
Conversation
`global` inside a class body is parsed as a module declaration, and in
the following example has no body:
```ts
class C {
global x
}
```
`x` is parsed as a separate ExpressionStatement. This caused a crash in
emit because the code didn't expect a module declaration with no body.
| let statementsLocation: TextRange; | ||
| let statementsLocation: TextRange | undefined; | ||
| let blockLocation: TextRange | undefined; | ||
| const body = node.body!; |
Member
There was a problem hiding this comment.
Can we remove non null assertion here given that's what you are fixing.
Member
Author
There was a problem hiding this comment.
I just inlined the variable.
sheetalkamat
approved these changes
Apr 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
globalinside a class body is parsed as a module declaration, and inthe following example has no body:
xis parsed as a separate ExpressionStatement. This caused a crash inemit because the code didn't expect a module declaration with no body.
Fixes #35717