Skip to content

Add valueOf declarations for TypedArrays#36668

Merged
orta merged 1 commit intomicrosoft:masterfrom
wemeetagain:typedarray-valueof
Mar 13, 2020
Merged

Add valueOf declarations for TypedArrays#36668
orta merged 1 commit intomicrosoft:masterfrom
wemeetagain:typedarray-valueof

Conversation

@wemeetagain
Copy link
Copy Markdown
Contributor

  • There is an associated issue in the Backlog milestone (required)
  • Code is up-to-date with the master branch
  • You've successfully run gulp runtests locally
  • There are new or updated unit tests validating the change

Fixes #36656

@msftclas
Copy link
Copy Markdown

msftclas commented Feb 7, 2020

CLA assistant check
All CLA requirements met.

@sandersn sandersn added the For Backlog Bug PRs that fix a backlog bug label Feb 14, 2020
@sandersn sandersn requested review from orta and sandersn March 12, 2020 17:40
@orta
Copy link
Copy Markdown
Contributor

orta commented Mar 13, 2020

👋 looks good overall - thinking offhand, did you consider using this instead of the exact variable type?

@wemeetagain
Copy link
Copy Markdown
Contributor Author

👋

did you consider using this instead of the exact variable type?

I didn't, I guess I copied the style of the existing String#valueOf declaration.
Definitely willing to tweak as desired.

@orta
Copy link
Copy Markdown
Contributor

orta commented Mar 13, 2020

Nah, I think this is reasonable (I doubt someone will be making subclasses where this is useful etc)

Thanks @wemeetagain

@orta orta merged commit 4432178 into microsoft:master Mar 13, 2020
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Narrow the valueOf return type for TypedArrays

4 participants