Skip to content

Remove 'strict mode' from parsing and checking, and make it purely something purely checked at bind time.#3517

Merged
CyrusNajmabadi merged 5 commits intomasterfrom
strictMode
Jun 16, 2015
Merged

Remove 'strict mode' from parsing and checking, and make it purely something purely checked at bind time.#3517
CyrusNajmabadi merged 5 commits intomasterfrom
strictMode

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/compiler/binder.ts Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to comment that you picked 1 & 2 for the sake of truthiness.

Also, consider using a local const enum.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the const enum

@JsonFreeman
Copy link
Copy Markdown
Contributor

👍

CyrusNajmabadi added a commit that referenced this pull request Jun 16, 2015
Remove 'strict mode' from parsing and checking, and make it purely something purely checked at bind time.
@CyrusNajmabadi CyrusNajmabadi merged commit 718dc5b into master Jun 16, 2015
@CyrusNajmabadi CyrusNajmabadi deleted the strictMode branch June 16, 2015 06:41
@vladima vladima added the Breaking Change Would introduce errors in existing code label Jun 22, 2015
@vladima vladima added this to the TypeScript 1.6 milestone Jun 22, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Breaking Change Would introduce errors in existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants