Skip to content

Fix regression in mixin emit by removing unneeded line of code#34715

Merged
weswigham merged 2 commits intomicrosoft:masterfrom
weswigham:fix-regression-in-mixin-emit
Oct 24, 2019
Merged

Fix regression in mixin emit by removing unneeded line of code#34715
weswigham merged 2 commits intomicrosoft:masterfrom
weswigham:fix-regression-in-mixin-emit

Conversation

@weswigham
Copy link
Copy Markdown
Member

@weswigham weswigham commented Oct 24, 2019

Fixes #33739

Just removes a line of code added alongside the js declaration emitter whose purpose should be duplicated by the isValueSymbolAccessible on the following line, and so only served to break people ❤️

@weswigham weswigham merged commit 7cfa1df into microsoft:master Oct 24, 2019
@weswigham
Copy link
Copy Markdown
Member Author

weswigham commented Oct 24, 2019

@typescript-bot cherry-pick this into release-3.7

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Oct 24, 2019
@weswigham @typescript-bot
Cherry-pick PR microsoft#34715 into release-3.7
4015233 
Component commits:
4cb867b Fix regression in mixin emit by removing unneeded line of code

e3cc5e9 Double the test, double the fun
@typescript-bot typescript-bot mentioned this pull request Oct 24, 2019
Merged
@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Oct 24, 2019

Hey @weswigham, I've opened #34719 for you.

@weswigham weswigham deleted the fix-regression-in-mixin-emit branch October 24, 2019 21:09
DanielRosenwasser pushed a commit that referenced this pull request Oct 28, 2019
@DanielRosenwasser
Cherry-pick PR #34715 into release-3.7 (#34719)
87befe8 
Component commits:
4cb867b Fix regression in mixin emit by removing unneeded line of code

e3cc5e9 Double the test, double the fun
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn sandersn sandersn approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@weswigham weswigham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[3.7] Mixin is broken with TypeScript 3.7 beta and compilerOptions.declaration = true

3 participants

@weswigham @typescript-bot @sandersn