Fix reachability analysis for ?? operator#34702
Merged
ahejlsberg merged 6 commits intomasterfrom Oct 24, 2019
Merged
Conversation
Member
|
@typescript-bot cherry-pick this to release-3.7 |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Oct 24, 2019
Collaborator
|
Hey @RyanCavanaugh, I've opened #34710 for you. |
RyanCavanaugh
approved these changes
Oct 24, 2019
| return isOptionalChainRoot(node.parent) && node.parent.expression === node; | ||
| } | ||
|
|
||
| export function isQuestionQuestionExpression(node: Node) { |
Member
There was a problem hiding this comment.
The analogous factory function is createNullishCoalesce, so I think this should be isNullishCoalesce.
Member
Author
There was a problem hiding this comment.
Yeah, I guess, though for the uninitiated, nullish coalesce is meaningless and question question is self-explanatory. But hey, gotta have something for the quizzes. 😏
Member
There was a problem hiding this comment.
How else do you expect me to rig TSConf trivia?
Member
|
@typescript-bot cherry-pick this to release-3.7 |
Collaborator
|
Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.7 manually. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Oct 24, 2019
DanielRosenwasser
pushed a commit
that referenced
this pull request
Oct 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34635.