Revert old lkg and re lkg#33769
Merged
weswigham merged 2 commits intomicrosoft:masterfrom Oct 2, 2019
Merged
Conversation
Member
Author
|
@typescript-bot user test this |
Collaborator
|
Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 192dcaf. You can monitor the build here. It should now contribute to this PR's status checks. |
Collaborator
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Member
Author
|
Yah, fixes the |
RyanCavanaugh
approved these changes
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the LKG up to now, so we no longer have a breaking change that removed
typeArgumentsfromTypeReferencees, so thebuildProtocolpart of the LKG script isn't broken. We could have changed the LKG script, but editing the API to be backwards compatible is better for our consumers, too, so there's no need to fix the script just yet.This should unblock the
dockertests currently failing onmaster(which rely on being able to capture a fresh LKG).