Escape apparent substitution in synthesized NoSubstitutionTemplateLiterals#32580
Merged
andrewbranch merged 2 commits intomicrosoft:masterfrom Aug 5, 2019
Merged
Escape apparent substitution in synthesized NoSubstitutionTemplateLiterals#32580andrewbranch merged 2 commits intomicrosoft:masterfrom
andrewbranch merged 2 commits intomicrosoft:masterfrom
Conversation
sheetalkamat
reviewed
Aug 1, 2019
sheetalkamat
approved these changes
Aug 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32515
The issue was in re-printing a NoSubstitutionTemplateLiteral with an escaped would-be substitution in it:
`this is \${not} a substitution`. The node text simply becomesthis is ${not} a substitution, and when we were re-writing that to a new node, we were printing that text as-is, when we needed to insert a backslash before the${.