getPropertiesOfUnionOrIntersectionType: handle types with index signature#31979
Merged
sandersn merged 4 commits intomicrosoft:masterfrom Mar 13, 2020
Merged
Conversation
weswigham
approved these changes
Mar 10, 2020
sandersn
approved these changes
Mar 12, 2020
Member
sandersn
left a comment
There was a problem hiding this comment.
👍 I'll merge this after the typo is fixed.
| // The properties of a union type are those that are present in all constituent types, so | ||
| // we only need to check the properties of the first type | ||
| if (type.flags & TypeFlags.Union) { | ||
| // we only need to check the properties of the first type wihtout index signature |
Member
There was a problem hiding this comment.
Suggested change
| // we only need to check the properties of the first type wihtout index signature | |
| // we only need to check the properties of the first type without index signature | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #31565