Skip to content

add all-settled in promise#31085

Closed
Kingwl wants to merge 7 commits intomicrosoft:masterfrom
Kingwl:all-settled
Closed

add all-settled in promise#31085
Kingwl wants to merge 7 commits intomicrosoft:masterfrom
Kingwl:all-settled

Conversation

@Kingwl
Copy link
Copy Markdown
Contributor

@Kingwl Kingwl commented Apr 24, 2019

Fixes #31083

It's toooooooooo hard to write ten overload

Comment thread src/lib/esnext.promise.d.ts Outdated
@@ -0,0 +1,74 @@
/** @internal */
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this internal? if it was stripped by stripInternal (I don't think it is), it would create an invalid declaration file.

@Kingwl
Copy link
Copy Markdown
Contributor Author

Kingwl commented May 7, 2019

seems ci is broken

@RyanCavanaugh
Copy link
Copy Markdown
Member

Fixed merge conflicts, let's see how CI goes

@RyanCavanaugh
Copy link
Copy Markdown
Member

♥ line ending problems

@Kingwl
Copy link
Copy Markdown
Contributor Author

Kingwl commented Aug 27, 2019

Anything else needs me to update?🤔

@Kingwl
Copy link
Copy Markdown
Contributor Author

Kingwl commented Sep 16, 2019

🙋🏻‍♂️

@Kingwl Kingwl mentioned this pull request Oct 7, 2019
@Kingwl Kingwl closed this Oct 28, 2019
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proposal-promise-allSettled

4 participants