🤖 User test baselines have changed#29645
Merged
sandersn merged 1 commit intomicrosoft:masterfrom Jan 30, 2019
Merged
Conversation
466f45a to
eb295f4
Compare
sandersn
approved these changes
Jan 30, 2019
Member
sandersn
left a comment
There was a problem hiding this comment.
- Special understanding of readonly array/tuple.
- Don't create overlarge type unions.
Member
AFAIK there wasn't a perf issue with the types in chrome devtools - we need to investigate what that type was and adjust our heuristics so we don't error on it, IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh