🤖 User test baselines have changed#29403
Closed
typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
Closed
🤖 User test baselines have changed#29403typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Member
|
Haven't had time to review this yet; it's our change because chrome-devtools-frontend is locked. |
weswigham
reviewed
Jan 14, 2019
| node_modules/chrome-devtools-frontend/front_end/ui/ContextMenu.js(340,39): error TS2339: Property 'y' does not exist on type 'Event'. | ||
| node_modules/chrome-devtools-frontend/front_end/ui/ContextMenu.js(344,24): error TS2339: Property 'deepElementFromPoint' does not exist on type 'Event'. | ||
| node_modules/chrome-devtools-frontend/front_end/ui/ContextMenu.js(352,24): error TS2694: Namespace 'Common' has no exported member 'Event'. | ||
| node_modules/chrome-devtools-frontend/front_end/ui/ContextMenu.js(355,22): error TS2339: Property '_useSoftMenu' does not exist on type 'typeof ContextMenu'. |
Member
There was a problem hiding this comment.
Associated code is
static initialize() {
InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.SetUseSoftMenu, setUseSoftMenu);
/**
* @param {!Common.Event} event
*/
function setUseSoftMenu(event) {
UI.ContextMenu._useSoftMenu = /** @type {boolean} */ (event.data); // this line
}
}Looks like we're no longer recognizing namespace assignments within functions?
Member
There was a problem hiding this comment.
The only suspicious PR is your change to type resolution in
#29335. I’ll see if reverting that fixes this.
Member
There was a problem hiding this comment.
Yep, it's #29335. @weswigham I'll create a bug and assign it to you although I don't have time to create a standalone repro.
Member
|
Let's close these for now because (1) there aren't a lot of other changes (2) the fix might be easy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh