Skip to content

Fix crash on decorated field with negative literal type#29333

Merged
weswigham merged 1 commit intomicrosoft:masterfrom
weswigham:fix-decorator-crash
Jan 9, 2019
Merged

Fix crash on decorated field with negative literal type#29333
weswigham merged 1 commit intomicrosoft:masterfrom
weswigham:fix-decorator-crash

Conversation

@weswigham
Copy link
Copy Markdown
Member

Fixes #29329

Sadly the type of the thing we're switching over isn't guaranteed to be exhaustive because LiteralExpression isn't discriminable. A refactoring for another time, perhaps.

@weswigham weswigham merged commit d0aff9b into microsoft:master Jan 9, 2019
@weswigham weswigham deleted the fix-decorator-crash branch January 9, 2019 22:24
errendir added a commit to errendir/TypeScript that referenced this pull request Jan 14, 2019
* origin/master: (1082 commits)
  Fix unneeded cast lints (microsoft#29383)
  Extracted compilerOptions setting to helper function
  Added codefix to enable experimentalDecorators in the user's config file
  Add tests for noLib with <reference lib> and bundling.
  Add tests for noLib with <reference lib>.
  Do not process library reference directives with noLib set.
  emit jsx type arguments
  Allow circular umd-merged-with-augmentation refs to resolve to the module as intended (microsoft#29335)
  Allow nonnull assertions in references (microsoft#29351)
  Accept new baselines
  Add regression tests
  Improve logic that determines when to resolve conditional types
  Update user baselines (microsoft#29336)
  Fix crash (microsoft#29333)
  Exclude JSDoc @extends from 'super()' checks (microsoft#29308)
  Fix existing test
  Verify that completion with new identifier location returns isNewIdentifierLocation: true Fixes microsoft#24009
  Fix the failing test case
  There is no need to check for file presence when trying to rename imports based on file rename Fixes microsoft#29031
  Fix gulp baseline-accept (microsoft#29301)
  ...
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants