Remove unused overloads of 'deduplicate' and 'deduplicateSorted'#26589
Merged
RyanCavanaugh merged 2 commits intomasterfrom Sep 6, 2018
Merged
Remove unused overloads of 'deduplicate' and 'deduplicateSorted'#26589RyanCavanaugh merged 2 commits intomasterfrom
RyanCavanaugh merged 2 commits intomasterfrom
Conversation
RyanCavanaugh
approved these changes
Aug 22, 2018
RyanCavanaugh
approved these changes
Aug 22, 2018
rbuckton
reviewed
Aug 22, 2018
| return array.length === 0 ? [] : | ||
| array.length === 1 ? array.slice() : | ||
| comparer ? deduplicateRelational(array, equalityComparer, comparer) : | ||
| comparer ? deduplicateRelational(array, equalityComparer!, comparer) : |
Contributor
There was a problem hiding this comment.
Do we pass undefined for equalityComparer to deduplicate anywhere? It seems like something we should verify since we're changing the signatures.
Contributor
There was a problem hiding this comment.
It appears that deduplicateRelational will throw if equalityComparer is undefined: https://github.com/Microsoft/TypeScript/pull/26589/files#diff-66cec844e251a1918deb897eabca206bR767
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We never pass undefined inputs into either of these functions.