Fix lint race when not running tests in parallel#25235
Merged
weswigham merged 1 commit intomicrosoft:masterfrom Jun 26, 2018
Merged
Fix lint race when not running tests in parallel#25235weswigham merged 1 commit intomicrosoft:masterfrom
weswigham merged 1 commit intomicrosoft:masterfrom
Conversation
RyanCavanaugh
approved these changes
Jun 26, 2018
Member
RyanCavanaugh
left a comment
There was a problem hiding this comment.
Explains a lot of weirdness. LGTM but why is the node-start project updated in this PR?
Member
Author
|
@RyanCavanaugh its reference updates anytime (user) tests are run (or submodules are updated); despite being ignored it gets added by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
runLinterAndCompleteandfinishwere invokingcomplete(the first when linting was actually done, the second immediately), causingcompleteto be called for the lint's prerequisite build before the task was actually done (and more times and required), leading tolintrunning before is prerequisitetsbuildtask was complete, resulting in an error if lint rules were not already built.The
jakeAPI isn't exactly forgiving when it comes to ensuring your tasks only complete once when used in the way we've authored; as it turns out,jakesupports async tasks returning promises (and if you do so, you no longer have to configure the async flag) - it would be much safer to be using them.