Clean up browserify task, remove unused 'debugMode.js' script#25211
Merged
Clean up browserify task, remove unused 'debugMode.js' script#25211
Conversation
weswigham
approved these changes
Jun 25, 2018
Member
weswigham
left a comment
There was a problem hiding this comment.
Looks good provided you've verified that the sourcemaps still work in runtests-browser (namely that they actually map back to the right files on disk).
| "extends": "../tsconfig-base", | ||
| "compilerOptions": { | ||
| "outFile": "../../lib/tsc.js", | ||
| "outFile": "../../built/local/tsc.release.js", |
Member
There was a problem hiding this comment.
...this was potentially building directly into lib? 😱
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up our
"browserify"build task in gulp and removes the dependency for thesorcerypackage. This also removes the now unused debugMode.js script and buildssrc/tsc/tsconfig.release.jsonin a build task in both the gulpfile and the jakefile.