Use / in paths in the auto-generated files' header#24883
Merged
Conversation
RyanCavanaugh
approved these changes
Jun 12, 2018
| let result = | ||
| "// <auto-generated />\r\n" + | ||
| "// generated from '" + inputFilePathRel + "' by '" + thisFilePathRel + "'\r\n" + | ||
| "// generated from '" + inputFilePathRel + "' by '" + thisFilePathRel.replace(/\\/g, '/') + "'\r\n" + |
Member
There was a problem hiding this comment.
Should you be using path.normalize instead?
Member
There was a problem hiding this comment.
Actually yes please use path.normalize
DanielRosenwasser
requested changes
Jun 12, 2018
| let result = | ||
| "// <auto-generated />\r\n" + | ||
| "// generated from '" + inputFilePathRel + "' by '" + thisFilePathRel + "'\r\n" + | ||
| "// generated from '" + inputFilePathRel + "' by '" + thisFilePathRel.replace(/\\/g, '/') + "'\r\n" + |
Member
There was a problem hiding this comment.
Actually yes please use path.normalize
Member
Author
|
Nope, that's backwards. The intent of this change is to use the same character regardless of platform. We used a regex replace because the result doesn't really matter, especially now that it's gitignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes spurious checked-out file after building on Unix machines.