getEditsForFileRename: Handle old file still being present#24328
Merged
getEditsForFileRename: Handle old file still being present#24328
Conversation
| : program.getResolvedModuleWithFailedLookupLocationsFromCache(importStringLiteral.text, sourceFile.fileName); | ||
| if (resolved && contains(resolved.failedLookupLocations, oldFilePath)) { | ||
| // We may or may not have picked up on the file being renamed, so maybe successfully resolved to oldFilePath, or maybe that's in failedLookupLocations | ||
| if (resolved && contains([resolved.resolvedModule && resolved.resolvedModule.resolvedFileName, ...resolved.failedLookupLocations], oldFilePath)) { |
Member
There was a problem hiding this comment.
I would have you rather check resolvedModule.resolvedFileName separately and failedLookups separately to ensure not creating duplicate array just to check if it has the value.
mjbvz
approved these changes
May 22, 2018
Contributor
mjbvz
left a comment
There was a problem hiding this comment.
Looks good. I wasn't able to repro the issue using this build.
Thanks!
Contributor
|
@Andy-MS please port to release-2.9 |
mhegazy
approved these changes
May 23, 2018
sheetalkamat
approved these changes
May 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mjbvz Mentioned having issues with this -- one possibility is that we don't update the program soon enough. This PR would make
getEditsForFileRenamework even if the program still contains the old file.@mjbvz Please test this out.