Fix jsx element parsing within ternary#24149
Merged
weswigham merged 1 commit intomicrosoft:masterfrom May 16, 2018
Merged
Conversation
RyanCavanaugh
approved these changes
May 16, 2018
sandersn
approved these changes
May 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24121
Previously type parsing wasn't allowed to "fail" (return
undefined), however to support speculative arrow parsing in JSX, it must be able to fail (as we could be inside a speculative arrow parse in a conditional and attempt to parse a jsx tag as an arrow function type start, which needs to fail when, eg, we encounter a child or end tag).