Use ts-check instead of ts-node to avoid transpilation overhead on gulp invoke#23486
Merged
weswigham merged 1 commit intomicrosoft:masterfrom Apr 17, 2018
Merged
Use ts-check instead of ts-node to avoid transpilation overhead on gulp invoke#23486weswigham merged 1 commit intomicrosoft:masterfrom
weswigham merged 1 commit intomicrosoft:masterfrom
Conversation
weswigham
commented
Apr 17, 2018
| @@ -1057,51 +1105,6 @@ gulp.task("build-rules", "Compiles tslint rules to js", () => { | |||
| .pipe(gulp.dest(dest)); | |||
| }); | |||
|
|
|||
| const lintTargets = [ | |||
Member
Author
There was a problem hiding this comment.
This chunk of code was unused (we swapped to shelling out to tslint directly once they added project mode), so I removed it while I was here.
RyanCavanaugh
approved these changes
Apr 17, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
ts-nodenow does an immensely costly full-typecheck (of all TS in the tree), and waiting full seconds just forgulpis unreasonable (if it doesn't crash from size limits, like it does for us).However, the
Gulpfileis still strongly typed, thanks to@ts-check, which we did not have back when we first started using aGulpfile.ts.Fixes #23479