Combine getTouchingWord and getTouchingPropertyName#22127
Merged
1 commit merged intomasterfrom Apr 12, 2018
Merged
Conversation
Author
|
@mhegazy @sheetalkamat @armanio123 Could someone review? |
sheetalkamat
approved these changes
Apr 12, 2018
This was referenced Apr 12, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getTouchingPropertyNameis justgetTouchingWord, except it allows us to be exactly at the end of a StringLiteral, whilegetTouchingWordonly allows us to be exactly at the end of an Identifier, and requires us to be at least one character before the end of a string literal. (They were both added in #752.) I don't think there are any cases where this difference actually matters, so we can just usegetTouchingPropertyNameconsistently, which allows some code to be abstracted infindAllReferenceswhich previously used one function in some places and the other function in others.