Skip to content

Apply 'no-unnecessary-qualifier' lint rule#22009

Merged
3 commits merged intomasterfrom
no-unnecessary-qualifier
Mar 1, 2018
Merged

Apply 'no-unnecessary-qualifier' lint rule#22009
3 commits merged intomasterfrom
no-unnecessary-qualifier

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 17, 2018

Removes ts. when we are already inside the ts namespace.

@ghost ghost force-pushed the no-unnecessary-qualifier branch from 1db71b1 to b1769e0 Compare February 17, 2018 02:56
@ghost ghost force-pushed the no-unnecessary-qualifier branch from b1769e0 to 8c3ca0d Compare February 17, 2018 03:12
@DanielRosenwasser
Copy link
Copy Markdown
Member

How did you determine which cases were unnecessary qualification vs. when a shadowing occurred?

@ajafff
Copy link
Copy Markdown
Contributor

ajafff commented Feb 17, 2018

The rule uses getSymbolsInScope and compares the qualified symbol with the unqualified one.

@ghost ghost force-pushed the no-unnecessary-qualifier branch from 5283d13 to 9c8a919 Compare March 1, 2018 21:52
@ghost ghost merged commit a564912 into master Mar 1, 2018
@ghost ghost deleted the no-unnecessary-qualifier branch March 1, 2018 22:20
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants