API: fix types for strict null checks#20909
Merged
mhegazy merged 1 commit intomicrosoft:masterfrom Jan 6, 2018
Merged
Conversation
errendir
added a commit
to errendir/TypeScript
that referenced
this pull request
Jan 7, 2018
* origin/master: (61 commits) Add release-2.7 to covered branches LEGO: check in for master to temporary branch. LEGO: check in for master to temporary branch. API: fix types to undefined union (microsoft#20909) Fix conflict between formatting rules (microsoft#21038) Switch to block-bodied lambda Better name for deferred mapped type:ReverseMapped Slightly simplify getCodeActions Make fixCannotFindModule return an empty array if there is no code action In checkAndAggregateReturnExpressionTypes, treat MethodDeclaration in an object literal same as a FunctionExpression (microsoft#20052) Return string completions for indexed access types Check for unused getter/setter in classes (microsoft#21013) Only replace `implements` with a comma if the heritage clauses are sensible Refine extends-to-implements code fix Fix version of @types/node to 8.5.5 (microsoft#21019) fix microsoft#20449, insert space between decorators (microsoft#20491) findConfigFile can return undefined (microsoft#20556) Allowed trailing commas in type parameter/argument lists (microsoft#20599) Added localization instructions to CONTRIBUTING.md (microsoft#20451) Simplify marker names ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While experimenting with
ParseConfigHostI noticed that not all parameters toreadDirectoryare always defined. This PR updates these parameter's type annotations.In addition I implemented a
CompilerHostand noticed that I cannot simply return the result ofts.resolveModuleName(...).resolvedModulefromCompilerHost.resolveModuleNamesbecause the returned array does not acceptundefinedvalues. The code that uses this array has checks for undefined values, so I figured the return type annotation is not correct.