Merged
Conversation
Member
Author
|
Note that #19979 broke parsing of arrow functions in one case. See here: https://github.com/Microsoft/TypeScript/pull/19979/files#diff-5158944ac4103f3398a8f41ae0139069 The commit above to improve lookahead for arrow functions fixes this. |
Member
Author
|
@mhegazy I'd like to merge this one, so take a look when you can. Other than the 6-7% improvement it contains a fix to a regression. See above. |
mhegazy
approved these changes
Nov 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes our handling of JSDoc comment parsing resulting in parse time improvements of 6-7%. Previously, on every AST node where a JSDoc comment could occur we would always re-scan the whitespace preceding the node during finalization of the node object. Now, the scanner provides a flag to indicate if any JSDoc comments precede the current node, and we use this information to only process JSDoc comments when they are actually present.