Adds tracking for failed tests, re-running failed tests.#16701
Adds tracking for failed tests, re-running failed tests.#16701
Conversation
|
Gotta take a look but this is great :) 🍰 |
| inspect: process.env.inspect || process.env["inspect-brk"] || process.env.i, | ||
| host: process.env.TYPESCRIPT_HOST || process.env.host || "node", | ||
| browser: process.env.browser || process.env.b || "IE", | ||
| bail: process.env.bail || false, |
There was a problem hiding this comment.
Exit on the first failed test. This already exists in jakefile.js
| } | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
nit: either we remove this or we add it everywhere with comments
| * @param keepFailed {Boolean} | ||
| * @param fn {Function} | ||
| */ | ||
| FileReporter.writeFailures = function (file, failures, keepFailed, fn) { |
There was a problem hiding this comment.
Could you rename file to fileName or filePath
There was a problem hiding this comment.
I only added it here for better intellisense.
c341c4b to
ede814b
Compare
| var reporterOptions = this.reporterOptions = options.reporterOptions || {}; | ||
| reporterOptions.file = reporterOptions.file || ".failed-tests"; | ||
| reporterOptions.keepFailed = reporterOptions.keepFailed || false; | ||
| reporterOptions.reporter = reporterOptions.reporter; |
There was a problem hiding this comment.
this looks like a rigid idiom, but it still bugs me. Can you remove it?
sandersn
left a comment
There was a problem hiding this comment.
Just one comment. Otherwise looks good.
|
@rbuckton can you refresh this PR? |
RyanCavanaugh
left a comment
There was a problem hiding this comment.
Leaving a review to get this out of my pending PR reviews list
|
Superseded by #25004. |
This change adds the following capabilities:
runtestsorruntests-parallel), any failing tests will be written to a .failed-tests file.--optsoption.--grepoption.jake runtests failed=trueorgulp runtests --failedwill run only the failing tests from the last test run.failedoption will be superseded by thetestsoption, if both are provided.failedoption is not currently supported on theruntests-paralleltask.keepFailed=trueto jake or--keepFailedto gulp.Examples (jake)
Examples (gulp)