Skip to content

Remove vestiges of WScript support#14448

Merged
mhegazy merged 2 commits intomicrosoft:masterfrom
DLehenbauer:removeWScript
Mar 16, 2017
Merged

Remove vestiges of WScript support#14448
mhegazy merged 2 commits intomicrosoft:masterfrom
DLehenbauer:removeWScript

Conversation

@DLehenbauer
Copy link
Copy Markdown
Contributor

@DLehenbauer DLehenbauer commented Mar 4, 2017

WSH is no longer in use - Fixes #14414

@msftclas
Copy link
Copy Markdown

msftclas commented Mar 4, 2017

@DLehenbauer,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link
Copy Markdown

msftclas commented Mar 4, 2017

@DLehenbauer, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@DLehenbauer
Copy link
Copy Markdown
Contributor Author

DLehenbauer commented Mar 10, 2017

Force pushed an update to fix the CRLF mismatch in 'Jakefile.js' that snuck in when I resolved an earlier conflict in this file through Github's web UI. (The resulting diff is now much smaller.)

RyanCavanaugh
RyanCavanaugh reviewed Mar 10, 2017
View reviewed changes
Comment thread src/harness/harness.ts Outdated
IO = IOImpl.Network;
break;
default:
throw new Error(`Unknown value '${environment}' for ExecutionEnvironment'.`);
Copy link
Copy Markdown
Member

@RyanCavanaugh RyanCavanaugh Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infinitesimal nit which should be ignored: Missing (or extraneous) ' here

Copy link
Copy Markdown
Contributor Author

@DLehenbauer DLehenbauer Mar 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I'll bundle the fix w/a future PR. (Thx.)

RyanCavanaugh
RyanCavanaugh approved these changes Mar 10, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

DLehenbauer
DLehenbauer commented Mar 15, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@DLehenbauer DLehenbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Thanks!)

@RyanCavanaugh
Copy link
Copy Markdown
Member

RyanCavanaugh commented Mar 16, 2017

@mhegazy good to merge?

@mhegazy mhegazy merged commit 7ead44f into microsoft:master Mar 16, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DLehenbauer @msftclas @RyanCavanaugh @mhegazy @DanielRosenwasser