Skip to content

Fixing default typeRoots on Windows#13461

Merged
mhegazy merged 2 commits intomicrosoft:masterfrom
flekmatik:getDefaultTypeRoots-fix
Feb 15, 2017
Merged

Fixing default typeRoots on Windows#13461
mhegazy merged 2 commits intomicrosoft:masterfrom
flekmatik:getDefaultTypeRoots-fix

Conversation

@flekmatik
Copy link
Copy Markdown
Contributor

@flekmatik flekmatik commented Jan 13, 2017

Without this function ignores backslashes

Fixes #13460

Without this function ignores "\"
@msftclas
Copy link
Copy Markdown

Hi @flekmatik, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@mhegazy mhegazy assigned ghost Jan 16, 2017
@ghost
Copy link
Copy Markdown

ghost commented Jan 17, 2017

@vladima Shouldn't the host be returning a normalized path in the first place? This seems like the wrong place to do it.

@flekmatik
Copy link
Copy Markdown
Contributor Author

I am wondering why more people didn't report this bug. References with: "/// <reference types=" are not very dev friendly without it on windows. Maybe it's not widely used yet. Or they don't know that it should search in parent dirs too

@mhegazy mhegazy merged commit e4d7dc4 into microsoft:master Feb 15, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants