You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think that the old behaviour was wrong and the current behaviour is correct. When a tsconfig file is placed in a subdirectory, gulp-typescript would emit incorrect paths, see ivogabe/gulp-typescript#461. Though this old behaviour seemed to work here.
Here's what happens: src/compiler/tsconfig.json sets "outFile": "../../built/local/tsc.js". In the gulpfile, localCompilerProject.src() sets the base path of the source files to root/src/compiler. The generated file should then have root/src/compiler as base path too, and ../../built/local/tsc.js (value of outFile) as relative path. gulp.dest(".") then causes that this file is written as ../../built/local/tsc.js (thus, outside of the project directory).
Previously, the base path would be wrongly set to "" (yes, an empty string), which caused that the file would we written as built/local/tsc.js.
This can be fixed by using gulp.dest("src/compiler") (the location of the tsconfig file, such that the outFile is evaluated relative to this location), setting outFile: "built/local/tsc.js" (this path is relative to project root, so gulp.dest(".") works fine), or setting outFile: "tsc.js" and gulp.dest("built/local").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13335 and #13352