Skip to content

space-before-function-paren#13045

Merged
mhegazy merged 2 commits intomicrosoft:masterfrom
aochsner:fix-12234
Dec 21, 2016
Merged

space-before-function-paren#13045
mhegazy merged 2 commits intomicrosoft:masterfrom
aochsner:fix-12234

Conversation

@aochsner
Copy link
Copy Markdown

@aochsner aochsner commented Dec 20, 2016

Adding option InsertSpaceBeforeFunctionParenthesis
Should be optional
Typically used to support http://eslint.org/docs/rules/space-before-function-paren

Fixes #12234

Fixes #

Adding option InsertSpaceBeforeFunctionParenthesis
Should be optional
Typically used to support http://eslint.org/docs/rules/space-before-function-paren

Fixes microsoft#12234
@msftclas
Copy link
Copy Markdown

Hi @aochsner, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@aochsner
Copy link
Copy Markdown
Author

Realized that this test will fail... any suggestions as to how to fix? Guessing that it is conflicting w/ SpaceAfterFunctionInFuncDecl

/////*3*/var anonymousWithoutSpace = function() {};
goTo.marker('3');
verify.currentLineContentIs('var anonymousWithoutSpace = function () { };');

@aochsner
Copy link
Copy Markdown
Author

wrt anon functions looks like there's a different toggle:
InsertSpaceAfterFunctionKeywordForAnonymousFunctions

@aochsner
Copy link
Copy Markdown
Author

Okay. I added a couple more test cases for InsertSpaceBeforeFunctionParenthesis. Found InsertSpaceAfterFunctionKeywordForAnonymousFuctions to cover that case. Added InsertSpaceAfterConstructor to handle that case. That should cover the main cases that http://eslint.org/docs/rules/space-before-function-paren enforces.

Let me know what else should be done. Thanks!

@mhegazy mhegazy merged commit c90af3a into microsoft:master Dec 21, 2016
@mhegazy mhegazy mentioned this pull request Dec 21, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants