Skip to content

Support quick fixes for UMD global#12545

Merged
zhengbli merged 2 commits intomicrosoft:masterfrom
zhengbli:importFixForUMDGlobal
Dec 28, 2016
Merged

Support quick fixes for UMD global#12545
zhengbli merged 2 commits intomicrosoft:masterfrom
zhengbli:importFixForUMDGlobal

Conversation

@zhengbli
Copy link
Copy Markdown
Contributor

@zhengbli zhengbli commented Nov 28, 2016

Add quick fix support for the diagnostic message:

"'bluh' refers_to_a_UMD_global_but_the_current_file_is_a_module_Consider_adding_an_import_instead".

Comment thread src/services/codefixes/importFixes.ts Outdated

registerCodeFix({
errorCodes: [Diagnostics.Cannot_find_name_0.code],
errorCodes: [Diagnostics.Cannot_find_name_0.code, Diagnostics._0_refers_to_a_UMD_global_but_the_current_file_is_a_module_Consider_adding_an_import_instead.code],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: consider breaking into multiple lines.

@zhengbli zhengbli merged commit 69e0677 into microsoft:master Dec 28, 2016
@zhengbli zhengbli deleted the importFixForUMDGlobal branch December 28, 2016 23:04
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants