You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This makes two time/correctness tradeoffs that I think are worthwhile. Each saves approximately the same amount of time; on my machine the fourslash suite went from 1m55s to 1m05s
Use ts.transpile instead of a full compiler setup to compile the fourslash test code into JS. This means we won't see errors per se in the originating fourslash test, but people should be editing these in an editor that provides error highlighting anyway
Turn off the "high fidelity" typing behavior by default. High fidelity input was never intended to be used everywhere and it invokes a ton of LS calls that are irrelevant and haven't really found any bugs.
Use ts.transpile instead of a full compiler setup to compile the fourslash test code into JS. This means we won't see errors per se in the originating fourslash test, but people should be editing these in an editor that provides error highlighting anyway
This means that if you ever change something in goTo or edit in some way, you'll never know about it because you don't have all of your tests open in your editor. 😕
The reason will be displayed to describe this comment to others. Learn more.
We should use transpileModule (seeing as we claim that transpile is pretty much deprecated on the wiki) and reportDiagnostics: true. Just so we report parse errors, since they're going to get hit anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes two time/correctness tradeoffs that I think are worthwhile. Each saves approximately the same amount of time; on my machine the fourslash suite went from 1m55s to 1m05s
ts.transpileinstead of a full compiler setup to compile the fourslash test code into JS. This means we won't see errors per se in the originating fourslash test, but people should be editing these in an editor that provides error highlighting anyway