Skip to content

Welcome text and name change #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ali-hamud merged 2 commits into from
May 21, 2018
Merged

Welcome text and name change #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7bc2dd
Merged PR 4373: Welcome text, name change, and URL bug fix
Apr 30, 2018
83fc5c7
Merge remote-tracking branch 'powerbi/master'
May 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo/v2-demo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<body>
<header>
<div class="logo-text">
<div class="logo-text-span">Microsoft Power BI Embedded Sample</div>
<div class="logo-text-span">Microsoft Power BI Embedded Playground</div>
</div>
</header>
<div id="navbar-content">
Expand Down
12 changes: 12 additions & 0 deletions demo/v2-demo/sample.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,17 @@
</div>
</div>

<div id="welcome-text">
<h3>Welcome to the Power BI Embedded Playground</h3>
<br>
<div id="sample-tool-description">
While you are here, you can try many of our features without writing any code. <br>
Explore our APIs and see the results instantly so you know the options for your application. <br><br>
To get started, select the sample you want to explore, make any changes to get the results you want, and then click “Run”. <br><br>
<!-- You can check out our Tutorials for guided learning of new features. <br> -->
We add the latest features into the Playground, so you can explore them before adding them to your implementation.
</div>
</div>

<div id="mainContent">
</div>
4 changes: 4 additions & 0 deletions demo/v2-demo/scripts/report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ function OpenSamplesStep() {
// Hide Embed view in samples step.
$("#samples-step-wrapper").show();
$("#embed-and-interact-steps-wrapper").hide();

$("#welcome-text").show();
}

function OpenCodeStepFromNavPane()
Expand All @@ -48,6 +50,8 @@ function OpenCodeStep(mode, entityType, tokenType) {
$("#samples-step-wrapper").hide();
$("#embed-and-interact-steps-wrapper").show();

$("#welcome-text").hide();

let containers = $(".iframeContainer");
containers.removeClass(active_class);

Expand Down
19 changes: 17 additions & 2 deletions demo/v2-demo/style/layout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ header
}

#mainContent {
padding: 16px 8px 8px 8px;
padding: 0 8px 8px 8px;
width: 100%;
background: #F1F1F1;
}
Expand Down Expand Up @@ -117,7 +117,7 @@ header
table-layout: fixed;
width: 100%;
height: 330px;
margin-bottom: 15px;
margin: 15px 0 15px 0;
}

.bottomPanel {
Expand Down Expand Up @@ -146,6 +146,21 @@ header
height: 100%;
}

#welcome-text {
margin-top: 2px;
padding: 16px 24px 24px 24px;
background: #FFFFFF;
}

#sample-tool-header {
margin-bottom: 16px;
font-size: 24px;
}

#sample-tool-description {
max-width: 1000px;
}

@media only screen and (max-width: 1050px) {
.textAreaControl {
margin-right: 20px;
Expand Down