esp32: Allow excluding main.c for component builds. #18695
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code size report: |
This commit introduces a new CMake option MICROPY_COMPONENT_BUILD that allows excluding main.c from the build when MicroPython is integrated as an ESP-IDF component in an external project. When MicroPython is used as a component, the host application typically provides its own app_main() and mp_task() functions, leading to multiple definition errors at link time. This option allows out-of-tree builds to completely exclude main.c when the component integration pattern is used, where the host application manages MicroPython initialization directly. The option defaults to OFF, preserving existing behavior for all standard MicroPython builds. Example usage in an external project: set(MICROPY_COMPONENT_BUILD ON) Signed-off-by: Asogwa Emmanuel <asogwaemmanuel36@gmail.com>
c78f700 to
18ba043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit introduces a new CMake option MICROPY_COMPONENT_BUILD that allows excluding main.c from the build when MicroPython is integrated as an ESP-IDF component in an external project.
When MicroPython is used as a component, the host application typically provides its own app_main() and mp_task() functions, leading to multiple definition errors at link time.
The option defaults to OFF, preserving existing behavior for all
standard MicroPython builds.
Example usage in an external ESP-IDF project:
set(MICROPY_COMPONENT_BUILD ON)
Testing
I compiled the esp32 port for all supported targets out and in tree and the builds completed cleanly.