tests/multi_net: Exclude TLS/SSL tests for axTLS, and use getrandbits() for random port
#18675
+63
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The axTLS implementation of the tls module only has a basic set of features. In particular it doesn't support the CERT_REQUIRED constant nor DTLS, nor can it load the `ec_key.der` key when acting as a server. So skip tests that require these features, which ends up being all the ssl/tls tests. Signed-off-by: Damien George <damien@micropython.org>
The `getrandbits()` function is guaranteed to exist on all ports that have the `random` module (but `randrange()` is not). Signed-off-by: Damien George <damien@micropython.org>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18675 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 171 171
Lines 22298 22298
=======================================
Hits 21937 21937
Misses 361 361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts the
tests/multi_nettests so they run on the esp8266 port:ec_key.derkey when acting as a server. So skip tests that require these features, which ends up being all the ssl/tls mult tests (esp8266 can still run standard networking tests that use ssl/tls, just not the multi_net tests).random.getrandbits(), which is guaranteed to exist on all ports that have therandommodule (butrandrange()is not).Testing
Tested running all
multi_nettests on esp8266, esp32, RPI_PICO_W and unix ports. Apart from the TCP RST tests (covered by a separate PR #18547) the tests either pass or skip. In particular the updated ssl/tls tests still run and pass on all ports except esp8266.Trade-offs and Alternatives
esp8266 is now Tier 3, so we could just ignore test errors on that port. But I still find it useful to run tests on that hardware because it helps define a more minimal port. An esp8266 board is also included in the Octoprobe hardware set up, so it's good to have the tests passing or skipping there.
The change to use
getrandbits()is also potentially useful for other ports that don't enable all random features.