Fix NULL pointer dereference in ThreadController::remove#2
Merged
thebentern merged 1 commit intomeshtastic:masterfrom Oct 6, 2025
Merged
Fix NULL pointer dereference in ThreadController::remove#2thebentern merged 1 commit intomeshtastic:masterfrom
thebentern merged 1 commit intomeshtastic:masterfrom
Conversation
|
@thebentern @fifieldt I'm not sure who's managing this repo, but I ran into this same issue (while developing something that occasionally adds and removes a thread) and this PR's fix is correct and important 👍 Without this fix: crash and reboot |
|
@compumike thanks for the ping! This one slipped through the cracks in the soup of Github notifications 😅 |
|
@thebentern of course! i've declared notification bankruptcy 😂 |
|
It's nuts! I had to turn off some repos like the docs because I can't dig myself out in the morning
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a thread is removed its value is set to NULL. ThreadController::remove should check for a NULL entry before accessing the ThreadID.